| Message ID | 1429376067-9228-4-git-send-email-fabio.porcedda@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
Fabio, All, On 2015-04-18 18:54 +0200, Fabio Porcedda spake thusly: > Download it from the cvs repository because it is not avaialbe as a > downloadable file. > Also because a tag isn't avaiable use the date. > > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> > --- > package/expect/expect.hash | 2 -- > package/expect/expect.mk | 5 ++--- > 2 files changed, 2 insertions(+), 5 deletions(-) > delete mode 100644 package/expect/expect.hash > > diff --git a/package/expect/expect.hash b/package/expect/expect.hash > deleted file mode 100644 > index 09e68e7..0000000 > --- a/package/expect/expect.hash > +++ /dev/null > @@ -1,2 +0,0 @@ > -# Locally computed: > -sha256 b28dca90428a3b30e650525cdc16255d76bb6ccd65d448be53e620d95d5cc040 expect5.45.tar.gz > diff --git a/package/expect/expect.mk b/package/expect/expect.mk > index 8ef7e90..513be8f 100644 > --- a/package/expect/expect.mk > +++ b/package/expect/expect.mk > @@ -4,9 +4,8 @@ > # > ################################################################################ > > -EXPECT_VERSION = 5.45 > -EXPECT_SOURCE = expect$(EXPECT_VERSION).tar.gz > -EXPECT_SITE = http://downloads.sourceforge.net/project/expect/Expect/$(EXPECT_VERSION) > +EXPECT_VERSION = 2014/05/02 # v5.45.3 Do not put comments after the variable definition, it breaks things. Note that the example we have in the manual is wrong. Care to address that as well, please? Regards, Yann E. MORIN. > +EXPECT_SITE = cvs://expect.cvs.sourceforge.net:/cvsroot/expect > EXPECT_LICENSE = Public domain > EXPECT_LICENSE_FILES = README > > -- > 2.3.5 >
On Sun, Apr 19, 2015 at 10:11 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > Fabio, All, > > On 2015-04-18 18:54 +0200, Fabio Porcedda spake thusly: >> Download it from the cvs repository because it is not avaialbe as a >> downloadable file. >> Also because a tag isn't avaiable use the date. >> >> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> >> --- >> package/expect/expect.hash | 2 -- >> package/expect/expect.mk | 5 ++--- >> 2 files changed, 2 insertions(+), 5 deletions(-) >> delete mode 100644 package/expect/expect.hash >> >> diff --git a/package/expect/expect.hash b/package/expect/expect.hash >> deleted file mode 100644 >> index 09e68e7..0000000 >> --- a/package/expect/expect.hash >> +++ /dev/null >> @@ -1,2 +0,0 @@ >> -# Locally computed: >> -sha256 b28dca90428a3b30e650525cdc16255d76bb6ccd65d448be53e620d95d5cc040 expect5.45.tar.gz >> diff --git a/package/expect/expect.mk b/package/expect/expect.mk >> index 8ef7e90..513be8f 100644 >> --- a/package/expect/expect.mk >> +++ b/package/expect/expect.mk >> @@ -4,9 +4,8 @@ >> # >> ################################################################################ >> >> -EXPECT_VERSION = 5.45 >> -EXPECT_SOURCE = expect$(EXPECT_VERSION).tar.gz >> -EXPECT_SITE = http://downloads.sourceforge.net/project/expect/Expect/$(EXPECT_VERSION) >> +EXPECT_VERSION = 2014/05/02 # v5.45.3 > > Do not put comments after the variable definition, it breaks things. Could you explain it? > Note that the example we have in the manual is wrong. Care to address > that as well, please? Sure Thanks for reviewing.
Fabio, All, On 2015-04-19 12:12 +0200, Fabio Porcedda spake thusly: > On Sun, Apr 19, 2015 at 10:11 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > On 2015-04-18 18:54 +0200, Fabio Porcedda spake thusly: [--SNIP--] > >> +EXPECT_VERSION = 2014/05/02 # v5.45.3 > > > > Do not put comments after the variable definition, it breaks things. > > Could you explain it? I'm not sure what's going on here, but we've observed failures with that, most notably when downloading via git, and removing the comment made the error vanish. One wild guess is that the space(s) between the version and the '#' are part of the value, and that breaks later on. Really, just a wild guess... > > Note that the example we have in the manual is wrong. Care to address > > that as well, please? > > Sure Thanks! :-) Regards, Yann E. MORIN.
diff --git a/package/expect/expect.hash b/package/expect/expect.hash deleted file mode 100644 index 09e68e7..0000000 --- a/package/expect/expect.hash +++ /dev/null @@ -1,2 +0,0 @@ -# Locally computed: -sha256 b28dca90428a3b30e650525cdc16255d76bb6ccd65d448be53e620d95d5cc040 expect5.45.tar.gz diff --git a/package/expect/expect.mk b/package/expect/expect.mk index 8ef7e90..513be8f 100644 --- a/package/expect/expect.mk +++ b/package/expect/expect.mk @@ -4,9 +4,8 @@ # ################################################################################ -EXPECT_VERSION = 5.45 -EXPECT_SOURCE = expect$(EXPECT_VERSION).tar.gz -EXPECT_SITE = http://downloads.sourceforge.net/project/expect/Expect/$(EXPECT_VERSION) +EXPECT_VERSION = 2014/05/02 # v5.45.3 +EXPECT_SITE = cvs://expect.cvs.sourceforge.net:/cvsroot/expect EXPECT_LICENSE = Public domain EXPECT_LICENSE_FILES = README
Download it from the cvs repository because it is not avaialbe as a downloadable file. Also because a tag isn't avaiable use the date. Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> --- package/expect/expect.hash | 2 -- package/expect/expect.mk | 5 ++--- 2 files changed, 2 insertions(+), 5 deletions(-) delete mode 100644 package/expect/expect.hash