Message ID | 87fv8aaawv.fsf@aikidev.net |
---|---|
State | Changes Requested |
Delegated to: | Stefano Babic |
Headers | show |
Hi, On 08/04/2015 17:37, Vagrant Cascadian wrote: > On 2015-04-08, Stefano Babic wrote: >> On 01/04/2015 13:32, Stefano Babic wrote: >>> On 01/04/2015 04:46, Chris Kuethe wrote: >>>> Any chance of this being accepted into 2015.04? >> >> checpatch reports some issues by patch 2/2. Can you please fix them and >> resubmit ? Thanks ! > > Applying the patch below corrects most of the issues, but not all of the > reported issues: > > Cleaned 2 patches > 0 errors, 1 warnings, 0 checks for > 0001-ARM-mx5-move-to-a-standard-arch-board-approach.patch: > warning: arch/arm/Kconfig,440: please write a paragraph that describes > the config symbol fully > This is not an issue. Patch 1/1 can be applied without changes. > 0 errors, 1 warnings, 1 checks for > 0002-ARM-mx5-add-support-for-USB-armory-board.patch: > check: board/inversepath/usbarmory/usbarmory.c,382: Alignment should > match open parenthesis > warning: include/configs/usbarmory.h,41: line over 80 characters > Both of them must be fixed. > checkpatch.pl found 0 error(s), 2 warning(s), 1 checks(s) > > diff --git a/board/inversepath/usbarmory/usbarmory.c b/board/inversepath/usbarmory/usbarmory.c > index 3e60a86..573d586 100644 > --- a/board/inversepath/usbarmory/usbarmory.c > +++ b/board/inversepath/usbarmory/usbarmory.c > @@ -68,13 +68,13 @@ static void setup_iomux_sd(void) > NEW_PAD_CTRL(MX53_PAD_SD1_CMD__ESDHC1_CMD, SD_CMD_PAD_CTRL), > NEW_PAD_CTRL(MX53_PAD_SD1_CLK__ESDHC1_CLK, MX53_SDHC_PAD_CTRL), > NEW_PAD_CTRL(MX53_PAD_SD1_DATA0__ESDHC1_DAT0, > - MX53_SDHC_PAD_CTRL), > + MX53_SDHC_PAD_CTRL), > NEW_PAD_CTRL(MX53_PAD_SD1_DATA1__ESDHC1_DAT1, > - MX53_SDHC_PAD_CTRL), > + MX53_SDHC_PAD_CTRL), > NEW_PAD_CTRL(MX53_PAD_SD1_DATA2__ESDHC1_DAT2, > - MX53_SDHC_PAD_CTRL), > + MX53_SDHC_PAD_CTRL), > NEW_PAD_CTRL(MX53_PAD_SD1_DATA3__ESDHC1_DAT3, > - MX53_SDHC_PAD_CTRL), > + MX53_SDHC_PAD_CTRL), > MX53_PAD_EIM_DA13__GPIO3_13, > }; > > @@ -85,7 +85,7 @@ static void setup_iomux_led(void) > { > static const iomux_v3_cfg_t pads[] = { > NEW_PAD_CTRL(MX53_PAD_DISP0_DAT6__GPIO4_27, > - PAD_CTL_PUS_100K_DOWN), > + PAD_CTL_PUS_100K_DOWN), > }; > > imx_iomux_v3_setup_multiple_pads(pads, ARRAY_SIZE(pads)); > @@ -107,9 +107,9 @@ static void setup_iomux_pinheader(void) > NEW_PAD_CTRL(MX53_PAD_CSI0_DAT8__GPIO5_26, PAD_CTRL_UP), > NEW_PAD_CTRL(MX53_PAD_CSI0_DAT9__GPIO5_27, PAD_CTRL_UP), > NEW_PAD_CTRL(MX53_PAD_CSI0_DAT10__UART1_TXD_MUX, > - MX53_UART_PAD_CTRL), > + MX53_UART_PAD_CTRL), > NEW_PAD_CTRL(MX53_PAD_CSI0_DAT11__UART1_RXD_MUX, > - MX53_UART_PAD_CTRL), > + MX53_UART_PAD_CTRL), > NEW_PAD_CTRL(MX53_PAD_CSI0_DAT12__GPIO5_30, PAD_CTRL_UP), > }; > > @@ -119,7 +119,6 @@ static void setup_iomux_pinheader(void) > static void setup_iomux_unused_boot(void) > { > static const iomux_v3_cfg_t pads[] = { > - > /* Pulled-up pads */ > NEW_PAD_CTRL(MX53_PAD_EIM_A21__GPIO2_17, PAD_CTRL_UP), > NEW_PAD_CTRL(MX53_PAD_EIM_DA0__GPIO3_0, PAD_CTRL_UP), > @@ -155,7 +154,6 @@ static void setup_iomux_unused_nc(void) > ROM is executed so we force all the not connected pins > to a known state */ > static const iomux_v3_cfg_t pads[] = { > - > /* CONTROL PINS block */ > NEW_PAD_CTRL(MX53_PAD_GPIO_0__GPIO1_0, PAD_CTRL_UP), > NEW_PAD_CTRL(MX53_PAD_GPIO_1__GPIO1_1, PAD_CTRL_UP), > > Ok, but I need that the patch is sent again (no following up patch) with git send-email to avoid issues with the mailer. Best regards, Stefano Babic
diff --git a/board/inversepath/usbarmory/usbarmory.c b/board/inversepath/usbarmory/usbarmory.c index 3e60a86..573d586 100644 --- a/board/inversepath/usbarmory/usbarmory.c +++ b/board/inversepath/usbarmory/usbarmory.c @@ -68,13 +68,13 @@ static void setup_iomux_sd(void) NEW_PAD_CTRL(MX53_PAD_SD1_CMD__ESDHC1_CMD, SD_CMD_PAD_CTRL), NEW_PAD_CTRL(MX53_PAD_SD1_CLK__ESDHC1_CLK, MX53_SDHC_PAD_CTRL), NEW_PAD_CTRL(MX53_PAD_SD1_DATA0__ESDHC1_DAT0, - MX53_SDHC_PAD_CTRL), + MX53_SDHC_PAD_CTRL), NEW_PAD_CTRL(MX53_PAD_SD1_DATA1__ESDHC1_DAT1, - MX53_SDHC_PAD_CTRL), + MX53_SDHC_PAD_CTRL), NEW_PAD_CTRL(MX53_PAD_SD1_DATA2__ESDHC1_DAT2, - MX53_SDHC_PAD_CTRL), + MX53_SDHC_PAD_CTRL), NEW_PAD_CTRL(MX53_PAD_SD1_DATA3__ESDHC1_DAT3, - MX53_SDHC_PAD_CTRL), + MX53_SDHC_PAD_CTRL), MX53_PAD_EIM_DA13__GPIO3_13, }; @@ -85,7 +85,7 @@ static void setup_iomux_led(void) { static const iomux_v3_cfg_t pads[] = { NEW_PAD_CTRL(MX53_PAD_DISP0_DAT6__GPIO4_27, - PAD_CTL_PUS_100K_DOWN), + PAD_CTL_PUS_100K_DOWN), }; imx_iomux_v3_setup_multiple_pads(pads, ARRAY_SIZE(pads)); @@ -107,9 +107,9 @@ static void setup_iomux_pinheader(void) NEW_PAD_CTRL(MX53_PAD_CSI0_DAT8__GPIO5_26, PAD_CTRL_UP), NEW_PAD_CTRL(MX53_PAD_CSI0_DAT9__GPIO5_27, PAD_CTRL_UP), NEW_PAD_CTRL(MX53_PAD_CSI0_DAT10__UART1_TXD_MUX, - MX53_UART_PAD_CTRL), + MX53_UART_PAD_CTRL), NEW_PAD_CTRL(MX53_PAD_CSI0_DAT11__UART1_RXD_MUX, - MX53_UART_PAD_CTRL), + MX53_UART_PAD_CTRL), NEW_PAD_CTRL(MX53_PAD_CSI0_DAT12__GPIO5_30, PAD_CTRL_UP), }; @@ -119,7 +119,6 @@ static void setup_iomux_pinheader(void) static void setup_iomux_unused_boot(void) { static const iomux_v3_cfg_t pads[] = { - /* Pulled-up pads */ NEW_PAD_CTRL(MX53_PAD_EIM_A21__GPIO2_17, PAD_CTRL_UP), NEW_PAD_CTRL(MX53_PAD_EIM_DA0__GPIO3_0, PAD_CTRL_UP), @@ -155,7 +154,6 @@ static void setup_iomux_unused_nc(void) ROM is executed so we force all the not connected pins to a known state */ static const iomux_v3_cfg_t pads[] = { - /* CONTROL PINS block */ NEW_PAD_CTRL(MX53_PAD_GPIO_0__GPIO1_0, PAD_CTRL_UP), NEW_PAD_CTRL(MX53_PAD_GPIO_1__GPIO1_1, PAD_CTRL_UP),