diff mbox

[1/1] gnuradio: depends on shared libs

Message ID 1427737015-12068-1-git-send-email-gwenj@trabucayre.com
State Superseded
Headers show

Commit Message

Gwenhael Goavec-Merou March 30, 2015, 5:36 p.m. UTC
From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>

volk must be compiled with toolchain built with shared lib to avoid :
attempted static link of dynamic object `../lib/libvolk.so.0.0.0'

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
---
 package/gnuradio/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Baruch Siach March 30, 2015, 4:59 p.m. UTC | #1
Hi Gwenhael Goavec-Merou,

On Mon, Mar 30, 2015 at 07:36:55PM +0200, Gwenhael Goavec-Merou wrote:
> From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> 
> volk must be compiled with toolchain built with shared lib to avoid :
> attempted static link of dynamic object `../lib/libvolk.so.0.0.0'
> 
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> ---
>  package/gnuradio/Config.in | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/gnuradio/Config.in b/package/gnuradio/Config.in
> index 274afaa..bdf701c 100644
> --- a/package/gnuradio/Config.in
> +++ b/package/gnuradio/Config.in
> @@ -1,5 +1,6 @@
> -comment "gnuradio needs a toolchain w/ C++, IPV6, NPTL, largefile, wchar"
> +comment "gnuradio needs a toolchain w/ C++, IPV6, NPTL, largefile, wchar and shared libs"
>  	depends on BR2_USE_MMU
> +	depends on BR2_STATIC_LIBS
>  	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
>  		!BR2_TOOLCHAIN_HAS_THREADS_NPTL || !BR2_LARGEFILE || \
>  		!BR2_INET_IPV6

Should add '|| BR2_STATIC_LIBS' to this list of ORed dependencies to get the 
intended behaviour. Otherwise the comment will not be shown when 
!BR2_STATIC_LIBS.

baruch
diff mbox

Patch

diff --git a/package/gnuradio/Config.in b/package/gnuradio/Config.in
index 274afaa..bdf701c 100644
--- a/package/gnuradio/Config.in
+++ b/package/gnuradio/Config.in
@@ -1,5 +1,6 @@ 
-comment "gnuradio needs a toolchain w/ C++, IPV6, NPTL, largefile, wchar"
+comment "gnuradio needs a toolchain w/ C++, IPV6, NPTL, largefile, wchar and shared libs"
 	depends on BR2_USE_MMU
+	depends on BR2_STATIC_LIBS
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
 		!BR2_TOOLCHAIN_HAS_THREADS_NPTL || !BR2_LARGEFILE || \
 		!BR2_INET_IPV6
@@ -9,6 +10,7 @@  config BR2_PACKAGE_GNURADIO
 	depends on BR2_INET_IPV6 # boost
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_LARGEFILE # boost
+	depends on !BR2_STATIC_LIBS
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	depends on BR2_USE_MMU # use fork()
 	depends on BR2_USE_WCHAR # boost